Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFT calculator convergence test #292

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Conversation

bernstei
Copy link
Contributor

@bernstei bernstei commented Feb 7, 2024

Change the way calculator results copying checks for DFT calculator convergence to be less Vasp specific.
Add test for convergence status.

convergence to be less Vasp specific. Add test for convergence status.
passing a 3-tuple, since newest ASE EMT objects can't be pickled.

Fixed generic calculator auto-property-prefix guessing to work better
with tuples
@bernstei
Copy link
Contributor Author

bernstei commented Feb 8, 2024

Also had to update other tests to work with the latest ASE version, since they made EMT unpickleable, and also much faster, so a test that relied on a job timing out started failing.

@bernstei bernstei merged commit 5b6a5ea into main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant